Add ci and release github actions for easier maintenance #120
Conversation
|
Is there anyone who can merge this pull request, so we get an updated wheel in pypi? Thanks in advance |
There was a problem hiding this comment.
This looks really good. Thanks @mbachry . Now we need to find a maintainer to review/merge it.
Also Github Actions didn't trigger. Either it needs to be approved by a maintainer or I found that manually adding some starting setup in the "Actions" tab is usually sufficient to make it enabled.
|
|
||
| - name: Set test tag | ||
| if: ${{ !startsWith(github.event.ref, 'refs/tags/v') }} | ||
| run: git tag -f v0.0.0-dev0 |
There was a problem hiding this comment.
We shouldn't forget to remove it before merging.
|
|
||
| - name: Set test tag | ||
| if: ${{ !startsWith(github.event.ref, 'refs/tags/v') }} | ||
| run: git tag -f v0.0.0-dev0 |
| run: git tag -f v0.0.0-dev0 | ||
|
|
||
| - name: Build sdist | ||
| run: pipx run build --sdist |
There was a problem hiding this comment.
Let's maybe avoid pipx,
pip install build
python -m build --sdist
is the more standard way.
I think those .github files should go first into master branch and then github actions can be triggered. |
|
Yes, makes sense. Looks like it's blocked by #63 for now. |
Linux and Mac binary wheels were handled by travis builds, but it seems that travis is currently broken. Instead of fixing it, I suggest a single github action that builds wheels for all three platforms (thus replacing both travis and appveyor). The action is triggered by pushing a git tag with
vprefix (eg.v2.1.0) - this should be the only operation required to make a full release.Some changes:
build.ymlaction that builds and uploads a release on a new git tag; regular pushes upload to test.pypi.org (matches current behavior)version.py(the version is picked automatically from the current git tag)ci.ymlfor running testsHere's my test release: https://test.pypi.org/project/hiredis-mytest/0.0.0.dev0/#files (all currently supported platforms are there)
Note that
TEST_PYPI_API_TOKENandPYPI_API_TOKENpypi secrets would have to be created in github repo settings for pypi uploads to work.